Michiel Meeuwissen wrote:

Nico Klasens wrote:
Update of /var/cvs/applications/taglib/src/org/mmbase/bridge/jsp/taglib
In directory 
james.mmbase.org:/tmp/cvs-serv10927/applications/taglib/src/org/mmbase/bridge/jsp/taglib

Modified Files:
ContextReferrerTag.java CloudTag.java Log Message:
When The ContextReferrerTag is the CLoudTag then return null for the default 
locale otherwise return mmbase locale

But why?. It can break the on line 847:
   ResourceBundle bundle =     
ResourceBundle.getBundle("org.mmbase.bridge.jsp.taglib.resources.messages", 
getLocale());

ResourceBundle throws NPE if getLocale() would return null. So, it
should never do that.

I'll remove getDefaultLocale from CloudTag for now.

Michiel
Okay, I have reverted the CloudTag back to revision 1.135. I didn't have the time to look into it why it broke every locale logic in my app and came to the fix I checked in. Spend too much time today to track the real issue. Your simplification on checkLocale forces the cloud locale to be the mmbase locale. When you need that fix then some cloud.setLocale prevention should take place somewhere, because I am not going to pass around my locale on the request all the time.

Nico

_______________________________________________
Developers mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/developers

Reply via email to