Gerard van de Looi <[EMAIL PROTECTED]> skribis:
> I made two changes to the code that enhanced the taglib editor performance:
> 
> - I increased the size of the relatedCache variable to 1000. (Maybe this should be a 
>configuration parameter)
> - In the method org.mmbase.bridge.BasicNode.getRelations(int, int), I replaced the 
>following code:
> e=relbuilder.getRelations(getNumber(),otype, role);
> 
> by:
> 
> e=relbuilder.getRelated(getNumber(),otype, role);

That is quite odd. Relations are not the same as related nodes, are they?

> 
> I discovered that accesses to the InsRel table are quite a performance
> bottleneck. These changes increase the cached number of relations and make
> sure that this cache is used bij the taglibs. My question to you is: Is
> this a good approach? and if so, can someone make these changes to the
> repository?


Did you add the indices on insrel?

Indeed the results of getRelations are not cached in Insrel. Perhaps we
should make that as well?

Anyhow for a start I just made the relatedCache size configurable (by
caches.xml). In a first simple test I did not succeed to get even one entry
in it, but well, anybody can check it out simply now.

 Michiel



-- 
% Michiel Meeuwissen
% [EMAIL PROTECTED]
% http://www.purl.org/NET/mihxil/
% Vidu ankaux: http://www.uea.org/katalogo

Reply via email to