<Pierre van Rooden:> > > Modified Files: > > Tag: MMBase-1_6 > > Base64.java > > Log Message: > > RvM: Replace Base64 code for better performance and functionality. > > Can you explain what exactly was changed here? > What were the problems with the old code? > Perhaps you can add it in the bugtracker (seems to be working > again) as > an 'enhanchement'. Especially as it was also changed in the release > branch - it will be useful for the releasenotes of the upcoming patch.
I'll do so later on, but at present I'm not able to reach the bugtracker due to firewall restrictions (see my other posting). I've just added a few enhancement to the XML importer, one of which was to enable binary data to be imported using base64 encoding. For this I need a base64 decoder capable of efficiently decoding large chunks of data. The mmbase Base64 utility class provided some of this functionality, but very inefficient. Replacing the code by the third-party cody I found seemed the most sensible way to adapt the class. Changes are: - more efficient encoding/decoding (important when applied to binary files) - additional utility methods to handle different kind of data (in particular: encoding binary files to strings - this can be used when creating an xml importer input file) Btw, the third-party code was license-free, the source is referenced in the javadoc. Rob van Maris Senior Developer Finalist IT Group Java Specialists ------------------------------------------------------------- Amsterdam, The Netherlands Office: +31 20 5962321 (Direct) Mobile: +31 651444006 Fax: +31 20 5962331 -------------------------------------------------------------
