Rico Jansen wrote:
I have fixed the problem that the mm:include goes external when running
under Orion. Going external was causing problems as in our case it even goes off-site before getting back into webserver.
If this fix is good enough en doesn't break on for instance TomCat I will put it in CVS. So please test it under TomCat.
Attached is the modified IncludeTag.java
However, we are running into trouble with some JSP sites since
the behaviour is different. When the request goes external all
parameters are passed and when specified in the mm:include they overwrite
the ones in the request. However when it goes internal the parameters are
passed as well, but when specified they are added to the originals, resulting
in a List instead of 1 Value. I can understand this behaviour, but it severly
restricts the usefulness of the mm:include tag. As it is not possible to
override the values given in the request. Also it becomes very difficult to
built generic includes, which accept different sets of parameters and
include others based on those parameters. It would be nice if it would be
possible to change the behaviour as to when someone specifies a referid in
the mm:include, it overwrites the current value that comes from the request.
This should impact current non-Orion sites very little, as I suspect that
very few people use Lists as parameters in their jsp pages. It would also
diminish the impact on current Orion JSP sites when upgrading.
IIRC this has something to do with the jsp specs. The request may not be changed by an include or something like that...Johannes could you clarify this?
Gerard
