Modified Files:
Tag: MMBase-1_6
XMLEntityResolver.java Added Files:
Tag: MMBase-1_6
XMLUtilReader.java Log Message:
Rob: made maxFileSize configurable (#5947)
I was supposing that the utility configuration was a 1.7 hack, not 1.6.
I don't really mind (as long as config files are not required to be present, so the system is backwards compatible), but I suggest that, unless specified explicitly in a call, hacks are intended for the CVS Head version (1.7), and not for the patch.
If people agree, this would make voting for hacks a bit more transparent.
I would also like your views on checking in Hacks during a vote.
I think that, for small hacks, checking code in in CVS makes it easier for people to test it (actually I thought we had a discussion on this earlier but I may be wrong.).
So I would say you can check in a hack, for testing purposes only, provided:
- it does not exceed 5 new or changed classes
- it does not involve changes in behavior of module.core classes
- it is expressly stated that the code is for tetsing
- it is documented how to rollback changes.
I think this would make actually reviewuing code before voting is made easier. We might however, in those cases extend the voting window with two workdays, as we will be assuming people test the (pre-committed) hack.
-- Pierre van Rooden Mediapark, C 107 tel. +31 (0)35 6772815 "Never summon anything bigger than your head."
