Question about directionality in the bridge

[Marcel Maatkamp]

Hi,

I spot the following problem in mmbase 1.6 and 1.7 where the code 
tries to determine if directtionality is used. This secquence is triggered
when somebody does a <mm:getrelatednodes> in jsp:

org.mmbase.bridge.implementaion.BasicNode:
 
  getRelatedNodes(String type) {
    return getRelatedNodes(type,null,null);
  }

  getRelatedNodes(String type, String role, String direction) {
    .. 
     // determine directionality, see code for exact example
    boolean direction = (!ClusterBuilder.getSearchDir(direction) 
!=ClusterBuilder.SEARCH_ALL);

--- ---

org.mmbase.module.core.ClusterBuilder {

  int getSearchDir(String direction) { 
    if(direction==null) return lusterBuilder.SEARCH_EITHER;

--- ---

So this piece of code will always return 'true' whatever the configuration 
is for directionality. Isn't it better to use 'mmb.getInsRel().usesdir' instead?

gr,
 marcel maatkamp
 VPRO Digitaal