robmaris <[EMAIL PROTECTED]> wrote:
> Modified Files:
> FieldValueBetweenConstraint.java
> Log Message:
> RvM: reviewed todo comments.
> public interface FieldValueBetweenConstraint extends FieldConstraint {
> @@ -28,8 +29,6 @@
> * An integral numerical value, however, is represented by a string using
> * the standard <em>integer</em> format, i.e. without the decimal point
> * (e.g. "123" instead of "123.0").
> -
> - * @todo MM: why not Number getLowerLimit?
> */
> String getLowerLimit();
>
I think that I understand now that it returns a String because it is stored
as String (probably because in the resulting SQL query you finally need a
String). But it is a bit confusing because you set a Number and get a
String.
The same goes for FieldValueInConstraint, IIRC. You set "Number"s in it, but
get Strings out of it. I think I just ran into a bug in my 'clone' code
which did not understood this (so now I have to somehow convert the String
back to a Number, which will be rather ugly).
So, my question is, would it nog have been nicer to store the originally set
objects rather then converting them to String immediately? Then the 'get'
functions can work more intuitively and cloning will be simpler.
Michiel
--
Michiel Meeuwissen
Mediapark C101 Hilversum
+31 (0)35 6772979
nl_NL eo_XX en_US
mihxil'
[] ()
