Nico Klasens <[EMAIL PROTECTED]> wrote:
>
> Some weeks ago Martijn Houtman found a problem with the editwizards when a
> server is in a different timezone as the client. I made a fix for this,
but
> it is a big one. I would like some others to test my fix before I add it
to
> CVS (HEAD and MMBASE-1_7). It is very likely that I missed something.
> So could someone review the changes in the zip-file and let me know if
> everything is still working.
>
Hi Nico, thanks for your fast work. I browsed through the code and I have a
few remarks.

1) In validator.js the date object is used in the client timezone. I am not
sure if this works correct, especially with dtmin and dtmax. In the
errormessage there is even a mix of UTC and the local timezone

  d.getDate() + " " + (d.getMonth()+1) + " " + d.getUTCFullYear()

2) This is also the case in editwizard.jsp. Inserting a new date happens in
the client timezone, so there is still a mix of several timezones.

3) The timezone is implicit, which means that it is difficult to change the
code lateron when you don't want to use the server timezone. When you move a
site to another timezone alle dates will change, which is not always
desirable. It would be very nice if you can set the timezone at some place.

Martijn Houtman


Reply via email to