> Nico Klasens wrote: > > I tried to do the refactoring, but the method can't be getCloudVar. > > The interface CloudProvider has the same method. The > > edit.TransactionTag extends CloudReferrer and implements > > CloudProvider. A CloudProvider.getCloud returns the Cloud > member and a > > CloudReferrerTag.getCloud returns the parent Cloud member. When the > > method is renamed the CloudReferrerTag is shadowed by the > > TransactionTag.getCloudVar, but they don't have the same > > functionality. I renamed the method to getProviderCloudVar > > I don't see the problem > getCloudVar() returns the cloud variable belonging with the > specified tag. I don't see how it can be ambiguous? > If you need the 'cloud' variable of a Transaction tag I think > you need that transactions' cloud var, not its provider's? > I am not happy with 'getProviderCloudVar'.
Hello Pierre and others, I refactored with the knownledge which was inside the code. The getCloud (now getProviderCloudVar) was/is returning the provider's cloud. I didn't want to change functionality, but your view makes more sense. Shadowing the getCloudVar from the CloudReferrerTag in the TransactionTag is more logical. I guess I should have consulted the list before I did the change. We can easily change it in the HEAD. And if nobody has a problem with it I will do it for the 1.7 branch too. I will do the refactoring at the end of next week so please respond if I shouldn't do it in the 1.7 branch. IOW, the functionality for the TransactionTag will slightly change. The getCloudVar method will ooverride the new CloudReferrerTag.getCloudVar and implement the interface CloudProvider.getCloudVar(). Nico -------------------------------------------------- logic: The art of being wrong with confidence...
