[X] +1 (YES) BUT SEE BELOW
I'm in favor of this Hack, which is also, iirc a bugfix, but I have one rather important change regarding package/class naming:
- if this is a storage synchronisation issue, maybe the 'change' package should be in the storage layer. Also, if you name the property in mmbaseroot 'sharedstorage', maybe a better name would be 'shared' : i.e. org.mmbase.storage.shared. I also think maybe we could rename the MMBaseChangeInterface to Shared
- let's drop all the 'MMBase prefixes of classnames, while we are at it)
- I think the unicast code and the Changeinterface should also be under the change package.
- Maybe it is best to split this in a few extra subpackages, per implementation. My suggestion:
org.mmbase.storage.change: Shared (was: MMBaseChangeInterface) [or drop this altogether] SharedStorage (was: MMBaseSharedStorage) ShareManager (was org.mmbase.util.ChangeManager)
org.mmbase.storage.change.implementation.basic: BasicSharedStorage (was: MMBaseChangeDummy)
org.mmbase.storage.change.implementation.multicast: MultiCast (was: MMBaseMultiCast) MultiCastChangesReceiver MultiCastChangesSender WaitNode (was: MMBaseWaitNode, renamed from MMBaseMultiCastWaitNode)
org.mmbase.storage.change.implementation.unicast: UniCast (was: MMBaseUniCast) UniCastChangesReceiver UniCastChangesSender
Changing/moving MMBaseChangeInterface means minor changes in MMBase.java and ChangeManager. Moving/renaming ChangeManager means minor changes in the StorageManager classes and interface (i.e. renaming getChangeManager to getShareManager).
I can make the latter change prior to Nico's hack, is we agree on the package name.
Note that these are changes I propose initially for 1.8 - though I think it will speed up development/maintenance conciderably is we also do this in 1.7.
Better do this now, because I'll probable be doing it anyway when we kick off the nasty bits in the Optimalization project.
I'm ok with moving configuration to the util dir.
To not interrupt the vote, please us the following for further voting:
START OF CALL: 2004-09-22 END OF CALL: 2004-09-27
Accept the new multicast/unicast code:
[_] +1 (YES) [_] +0 (ABSTAIN ) [_] -1 (NO), because : [_] VETO, because:
Moving the code to org.mmbase.storage .shared :
[_] +1 (YES), in 1.7 and 1.8 [_] +1 (YES), only in 1.8 [_] +0 (ABSTAIN ) [_] -1 (NO), because : [_] VETO, because:
-- Pierre van Rooden Mediapark, C 107 tel. +31 (0)35 6772815 "Never summon anything bigger than your head."
