On Tue, 20 Nov 2018 at 16:29, Lars Knoll <[email protected]> wrote: > > > On 19 Nov 2018, at 21:59, Ville Voutilainen <[email protected]> > > wrote: > > > > On Mon, 19 Nov 2018 at 22:41, Thiago Macieira <[email protected]> > > wrote: > >> > >> On Monday, 19 November 2018 12:03:06 PST Ville Voutilainen wrote: > >>> I personally tend to split such things after an opening parenthesis. > >>> Getting back to allowing ctor-initializers to be written > >>> with a comma starting a line, I think we should just allow it; the > >>> benefit of not having noise in a diff seems to outweigh > >>> the minor aesthetics of it. > >> > >> It is allowed, unless the maintainer objects to it. > >> > >> I object to it in QtCore. > > > > I'm suggesting that you stop objecting to it. > > I suggest that we stop arguing about coding styles by defining one through a > tool (aka clang-format and one format file for all of Qt). I know that one > will never be perfect for all cases (and that you can always find corner > cases where manual formatting might be slightly better), but consistency and > finally stopping to argue about coding style esp. in code reviews (by > automating things) is more important. > > Cheers, > Lars
Here's a small record of intent: https://wiki.qt.io/index.php?title=Qt_Coding_Style&type=revision&diff=34756&oldid=34328 I wanted to link Lars' email, but that seems to have disappeared from the archive. Regards, Sze-Howe _______________________________________________ Development mailing list [email protected] https://lists.qt-project.org/listinfo/development
