Hi David, looks good in general.
I am however concerned about the static removeDir() method. This one is pretty much the equivalent of a 'rm -rf'. Since it's not limited to temporary directories, so it doesn't match the class. It's also a rather dangerous operation, and I'm worried we'll see bugs in it's usage leading to users home directories being blown away. Cheers, Lars On 11/16/11 6:13 PM, "ext David Faure" <[email protected]> wrote: >Hello, > >As previously discussed on qt5-feedback, I wrote QTemporaryDir and >submitted >it to gerrit at http://codereview.qt-project.org/#change,8297 >After a few reviews from Thiago (and redoing the implementation on >Windows) >it's now ready for submission. Thiago suggested that I post the header >file >here, to see if anyone had feedback on the (rather short) API. > >Actually I'll post the .cpp file too, since the documentation of the API >is >there :) > >-- >David Faure, [email protected], http://www.davidfaure.fr >Sponsored by Nokia to work on KDE, incl. KDE Frameworks >5_______________________________________________ >Development mailing list >[email protected] >http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
