On Friday, 23 de December de 2011 15.37.31, Olivier Goffart wrote:
> On Friday 23 December 2011 11:30:08 Thiago Macieira wrote:
> > Uploaded at:
> >
> > https://qt.gitorious.org/~thiago-intel/qt/thiago-intels-qtbase/commits/new
> > -
> > qglobalstatic
>
> I'm trying to review:
>
> You cannot use the QMutexPool in the QGlobalStaticControler.
> Because the creation of the global static will run user code that might
> create others global statics, or do something else that will also use the
> same mutex pool. Or just locking other mutex.  (hence locking multilples
> mutex, which may mean deadlock)
> (Especially since global statics might also be created under a lock or
> something)

When I wrote the implementation, the mutex pool was safe and never ran global
statics.

I'd support going back to that.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to