On Thu, Feb 16, 2012 at 06:13:17PM +0400, ext Denis Shienkov wrote: > Hi, Oswald. > > > which project is it? > > playground/qtserialport > ok, you are now an approver within your project. you should still try to stick to our commit policy and other guidelines, even if nobody from the "establishment" will double-check it.
fwiw, if you have the time and inclination i'd recommend that you rewrite the git history of the project - at the very least, the author names need fixing. > > how many people are involved? > > two. > you are in the "Qt Serial Port" group and the group is self-owned, so you can add other people. > Best regards, > Denis > > > 16.02.2012, 17:55, "Oswald Buddenhagen" <[email protected]>: > > > >> On Thu, Feb 16, 2012 at 04:49:32PM +0400, ext Denis Shienkov wrote: > >>> How to add changes to the Gerrit pero after a successful code review? > >>> Who is it supposed to do? > >> gerrit is a bit daft, so only approvers can push even if the change is > >> already approved. so you need to bug your reviewers to do it for you. > >>> Can I perform an review of my own code, and personally update the > >>> repository? > >>> And if so - how is it done? > >>> > >>> In the example projects in the playground. > >>> I have something confused. > >> in the case of playground projects we typically give extra rights to > >> their maintainers, as it is often enough unreasonable to wait for them > >> to become approvers or having people outside the subproject do reviews > >> all the time. which project is it? how many people are involved? > >> _______________________________________________ > >> Development mailing list > >> [email protected] > >> http://lists.qt-project.org/mailman/listinfo/development > _______________________________________________ > Development mailing list > [email protected] > http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
