On Monday, April 02, 2012 10:22:12 Thiago Macieira wrote: > Hello > > One of the duties of a maintainer is to ensure that every contribution to > the code he/she maintains is being reviewed. That is, if no one else > approves or rejects, the maintainer has the duty to make that happen. I've > done this in the past and approved based on +1 given by other people, or by > reviewing stuff myself. > > What are we supposed to do when no one else approves or rejects a commit > that we created ourselves? Or worse, when no one reviews at all?
I have had the same problem sometimes. (hint: http://codereview.qt-project.org/#change,21169) I've been lucky enough that ogoffart can usually review them. > > My question applies mostly to QtDBus, since I don't expect most people will > know anything about that module. I've (ab)used Stephen's goodwill to review > simple things, but I don't expect him to understand the message delivery > path for example. I plan to look into that stuff soon this week. > > What is the suggested procedure? IIRC, you need to make sure someone is educated enough about the stuff to give a +1, and then you can give a +2. I think that was documented in the procedures. I do that all the time with the CMake stuff, because the people who can review them are not approvers. What to do when that doesn't work I'm not sure. I guess it's a responsibility of other approvers and maintainers to try to review such things if you ask them to in such situations. Thanks, -- Stephen Kelly <stephen.ke...@kdab.com> | Software Engineer KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-Independent Software Solutions
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
