Hmm, perhaps there is a misunderstanding here. I am sorry for that if that is the case. I would not like to reference to the commit from its commit message. I would like to reference to other commits from a commit message. An example for this is:
1) Something changed in Qt5-base which requires further changes in Qt5-declarative for instance. 2) You would like to provide a link to the qt5-base change in the qt5-declarative change. Currently step 2) would include https://codereview.qt-project.org/<https://codereview.qt-project.org/#q,I9c239ff790a139c7820ef1aeced89d31320ae6b0,n,z>.... which points to the qt5-base change from the qt5-declarative change. It is hard coded so perhaps a keyword + id would be nicer, but I do not have strong opinion about this. Was just wondering if that made sense. Laszlo On Mon, Sep 17, 2012 at 1:00 PM, <[email protected]> wrote: > The line:**** > > Change-Id: I9c239ff790a139c7820ef1aeced89d31320ae6b0**** > > ** ** > > Is what identifies the code review.**** > > If you put that into the search box on gerrit, it gives the url:**** > > > https://codereview.qt-project.org/#q,I9c239ff790a139c7820ef1aeced89d31320ae6b0,n,z > **** > > ** ** > > Which shows the two reviews for this change (5.0 and 4.8 cherry pick)**** > > ** ** > > I think you could use that as a basis for generating urls to link to the > code review from the commit message.**** > > -- **** > > ------------------------------ > Subject to local law, communications with Accenture and its affiliates > including telephone calls and emails (including content), may be monitored > by our systems for the purposes of security and the assessment of internal > compliance with Accenture policy. > > ______________________________________________________________________________________ > > www.accenture.com >
_______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
