On 01/16/2013 05:47 PM, Thiago Macieira wrote: > On quarta-feira, 16 de janeiro de 2013 16.36.01, Robin Burchell wrote: >> Hi, >> >> I'd like to nominate Uli (psychon on IRC) for Approver status. >> >> Uli has some specialist knowledge that is often hard to find in any >> appreciable quality: he knows X11. He has helped out quite a bit when >> asked with reviewing, contributing to, and bouncing ideas off code >> around the xcb plugin as well as helping figure out bugs elsewhere in >> the libX11/xcb world that have hit us, from what I've heard. >> >> His dashboard can be found at:h >> ttps://codereview.qt-project.org/#dashboard,1001141 >> >> Would anyone like to second? > > Patches submitted: > https://codereview.qt-project.org/#q,owner:psychon%2540znc.in,n,z > > Reviews he's participated in: > https://codereview.qt-project.org/#q,reviewer:psychon%2540znc.in,n,z > > I have never heard of Uli's name before and I cannot find any email from him > to > this mailing list. Maybe all of the discussion on XCB was held on IRC and > there was nothing relevant to post to the rest of us. Also, he has less than > 50 reviews to his name, including changes that he was CC'ed on but did not > vote.
Do we have any guidelines on how many reviews and/or contributions should precede approver status? > I'd say that nominating for approver is a bit too early on those two > conditions. However, I'll lift my concerns if the people working on X11 say > that his expertise is needed for the continued progress of the codebase. He's definitely provided a lot of valuable input around the xcb platform plugin, so I for one would certainly trust him to approve changes in that area. +1 from me. -- Samuel _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
