On 21 March 2013 16:01, Thiago Macieira <[email protected]> wrote: > On quinta-feira, 21 de março de 2013 12.03.05, Giuseppe D'Angelo wrote: >> Replying to myself: upgrading to 8.32 actually causes failures in >> QString tests -- an expected failure passes (line 1165 in >> tst_qstring.cpp), as case folding support was finally added to PCRE. >> Although distributions probably haven't started shipping 8.32 yet, I >> don't like that very much... ideas? I only see: >> >> 1. skip the flaky data lines altogether >> 2. bump the minimum version required by Qt to 8.32 right now (and >> remove the expected failures from the tests) >> 3. make tst_qstring link to pcre and conditionally add the testlines >> depending on the PCRE version (!) > > I'd say upgrade the bundled copy and update the test to match, but leave the > minimum version unchanged. The bug is a corner-case.
And have the test fail if a system-wide 8.30 / 8.31 is picked? Does anyone know the situation on the CI machines? (Ubuntu ships 8.30 with 12.10, CI should use 12.04, so we should be fine...) -- Giuseppe D'Angelo _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
