Thanks, On gerrit there are 5 buttons the related to reply: Reply... Reply Done Discard Cancel Save
Which one actually send the reply so the reviewer views my reply? On Wed, Jan 1, 2014 at 7:37 AM, Mandeep Sandhu <[email protected]> wrote: > Hi, > > You should probably add a reviewer in Gerrit first. Look at the > maintainers page to see whom to add. Or you can even look at commit > log of the file you've touched to figure out a reviewer. > > Also, you might want to fix the sanity failure before adding reviewers! :) > > -mandeep > > > On Wed, Jan 1, 2014 at 8:59 AM, Jiergir Ogoerg <[email protected]> wrote: >> Hi, >> I have added for the 1st time code for review, please let me know if >> it's ready for review or if I have to do some additional work. >> >> 2 Submits: >> >> 1) https://codereview.qt-project.org/#change,74524 >> >> Cosmetic, removes trailing whitespaces: >> 2) https://codereview.qt-project.org/#change,74525 >> _______________________________________________ >> Development mailing list >> [email protected] >> http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
