I don't like the idea of removing QT_NO_DEBUG_STREAM. Even if Qt itself doesn't build with it (which is fixable), one might define it globally after it built, to avoid building an unnecessary code in his/3rd-party modules.
We already have #define qDebug QMessageLogger(__FILE__, __LINE__, Q_FUNC_INFO).debug Can not we simply #define qCDebug qDebug and add a respective overloads to QMessageLogger: void debug(const QLoggingCategory &category, const char *msg, ...) const; QDebug debug(onst QLoggingCategory &category) const; to make both `qCDebug(CATEGORY, "blah")` and `qCDebug(CATEGORY) << "blah"` work ? Regards, Konstantin 2014/1/6 Thiago Macieira <[email protected]> > On segunda-feira, 6 de janeiro de 2014 15:52:35, Koehne Kai wrote: > > So, anyone would mind if I remove QT_NO_DEBUG_STREAM from the code base? > I > > already started to do so for QtCore: > > https://codereview.qt-project.org/#change,74745 . But it's a lot of > > (tedious) work to do for the other modules too, so I thought I'd ask for > > opinions here before wasting more time > > Go ahead, I don't mind removing it. > > -- > Thiago Macieira - thiago.macieira (AT) intel.com > Software Architect - Intel Open Source Technology Center > > _______________________________________________ > Development mailing list > [email protected] > http://lists.qt-project.org/mailman/listinfo/development > >
_______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
