Yes, it should be pretty simple: Just remove qopenglproxy_win.cpp and leave everything else in place. This provides an excellent foundation for continuing the feature with a different approach.
The other modules are not an issue since the related changes have not been merged (with the exception of one very small change). At the same time this gives us an opportunity to revive https://codereview.qt-project.org/#change,79271 by moving isES() to QOpenGLContext and separating the two conceptually different queries (is this context ES / is my OpenGL implementation ES only) into two different functions. Cheers, Laszlo -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Sean Harmer Sent: 28. februar 2014 15:39 To: [email protected] Subject: Re: [Development] The Dynamic OpenGL on Windows Change On Friday 28 February 2014 14:53:02 Friedemann Kleint wrote: > Hi, > > >Thank you. Sorry this means it gets reverted for now. I think we all > > agree that having the common ES2 / desktop 2 subset magically work > everywhere on Windows > > Ok, technically speaking, how do we get this through the CI (considering > the modules which have follow-up changes ..can we leave the > functionality providing the isES() function in place? Sure, I think that's fine to leave in place. Only query I have around that is if it would make more sense being on the QOpenGLContext rather than QOpenGLFunctions. Thoughts? Cheers, Sean -- Dr Sean Harmer | [email protected] | Managing Director UK Klarälvdalens Datakonsult AB, a KDAB Group company Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322) KDAB - Qt Experts - Platform-independent software solutions _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
