Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: > diff --git a/src/gui/kernel/qopenglcontext.h > b/src/gui/kernel/qopenglcontext.h index ce34a2d..fce983f 100644 > --- a/src/gui/kernel/qopenglcontext.h > +++ b/src/gui/kernel/qopenglcontext.h > @@ -192,6 +192,17 @@ public: > QSet<QByteArray> extensions() const; > bool hasExtension(const QByteArray &extension) const; > > + static void *openGLModuleHandle(); > + > + enum OpenGLModuleType { > + DesktopGL, > + GLES2 > + };
Suggestion: OpenGL & OpenGLES2. Some non-desktop devices may have non-ES GL. The fact that we constantly refer to "desktop GL" erroneously should not influence the API. > + > + static OpenGLModuleType openGLModuleType(); > + > + bool isES() const; > + Suggestion: isOpenGLES() > --- a/src/gui/math3d/qvector2d.h > +++ b/src/gui/math3d/qvector2d.h > @@ -80,7 +80,7 @@ public: > float operator[](int i) const; > > float length() const; > > - float lengthSquared() const; > + float lengthSquared() const; //In Qt 6 convert to inline and constexpr Please use ### in the comment. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development