On Friday 04 July 2014 11:28:28 Oswald Buddenhagen wrote: > > - Asking people for a unit test in the bug tracker when we're not allowed > > to include this in Qt without submission via gerrit seems likely to cause > > conflict. I'd suggest either removing this section or explaining a > > mechanism that would allow the test to be used. > > > > > > i think some people in the project are a bit too dogmatic in this > regard. good test cases are typically so short and "unimaginative" that > they cannot reasonably violate copyright or patents, and can therefore > be safely submitted to gerrit by anyone. if you deem a test case to be > complex enough to be considered a creative work or invention (which > would usually be a bad sign to start with), you can still point the > reporter to the contribution process.
Also note that the testcase submitted by the reporter is usually not suitable for our unit test set. At least, I can't remember the last time anyone submitted a test that used QtTest macros. Most of the time, they come in the form of a GUI application that doesn't need a GUI. So any such tests need to be dissected by the actual bug fixing down to a real QtTest unit test. You may take the idea from the bug reporter's test, but most of the actual code won't be copied. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
