Should i continue pushing changes to dev branch or switch to 5.4? Is there anyone who will review during weekend? :-P
Иван Комиссаров 08 авг. 2014 г., в 19:21, Thiago Macieira <[email protected]> написал(а): > On Friday 08 August 2014 11:13:47 Marc Mutz wrote: >> Hi Lars, >> >> the above two classes are next to compled, but will fail the deadline by a >> few hours, max. The're both in the seventies, change-set wise, and have at >> one point or another been already accepted. >> >> https://codereview.qt-project.org/73945 >> https://codereview.qt-project.org/82170 >> >> I think they should be allowed to get in after the freeze, should they fail >> to make it before. > > If they require minor adjustments to make them pass the CI, it should be no > problem for them to go in during the weekend. > > If they require major overhaul because the CI found major faults, they should > get no exception. > > I think it's the former case, though. > -- > Thiago Macieira - thiago.macieira (AT) intel.com > Software Architect - Intel Open Source Technology Center _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
