On 24 February 2015 at 11:53, Radjino Bholanath <[email protected]> wrote: > 1. Do all developers (contributors and core developers) have to submit a code > review for every change? I’m asking because many projects only review changes > made by contributors.
The procedure is the same for everyone: all commits go through code review. There might be cases of self-approved commits but they're the very exception, not the norm. See also http://qt-project.org/wiki/Qt-Contribution-Guidelines and http://qt-project.org/wiki/Commit_Policy §12 > 2. Which code review tools are used? Gerrit: https://codereview.qt-project.org/ > 3. Are static analyzers used? If they are used: Yes, > a. Is passing the checks of the static analyzers necessary for a change to > be accepted? No. Only passing through CI is required, and CI isn't featuring such analyzers -- it simply builds the code and runs the autotests. > b. Which static analyzers are used? Coverity Scan checks the build once a week; various people play with the clang plugins over the codebase. Hope this helps, -- Giuseppe D'Angelo _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
