On Friday 05 June 2015 10:10:47 Frederik Gladhorn wrote:
> +    Q_TESTLIB_EXPORT QString qExtractTestData(const QString &dirName);
>  

This API isn't finished. The function needs to return a QTemporaryDir (which 
implies passing in by output parameter) so that the caller properly cleans up 
the extracted test data.

The rest looks good. I'd have put the qgpu_features function inside the QTest 
namespace, like everything else, though.
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to