Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

[Oswald Buddenhagen]

On Mon, Jun 08, 2015 at 01:17:26PM +0000, Lopes Yoann wrote:
> 
> > On 08 Jun 2015, at 15:38, Marc Mutz <marc.m...@kdab.com> wrote:
> > 
> > On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote:
> >> +    typedef QPair<qreal, qreal> FrameRateRange;
> > 
> > Should be a struct, not a QPair:
> > 
> >   FrameRateChange chg = ...;
> >   chg.first... // what's first???
> >   chg.second... // what's second???
> 
> It’s "…Range", not “…Change" ;) 
> I think having ‘first’ and ‘second’ for a range is pretty self-explanatory.
> 
well, "lower bound" and "upper bound" are more natural.
also, it's more consistent to standardize on "no QPair in the api".
_______________________________________________
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development