On Wednesday 05 August 2015 09:31:15 Eskil Abrahamsen Blomfeldt wrote: > It's not huge and all changes have been through peer reviews already (by > approvers in the Qt Project). The module has also been in active use for > a while. My plan was to upload the whole history including the peer > reviews (mostly done by Andy Nichols and me). > > How do we handle reviews beyond that? Should I make a patch to qt5.git > and collect comments there, or would it be better if I make a mock > change that includes the entire code base so that we can get inline > comments? I'm not sure how this has usually been done before. > > I'll try getting it up somewhere today at least, and we can at least try > to get it in time for Qt 5.6.
The release team decided the new modules should be released under Technical Preview for 5.6 (they came in 5 weeks past the deadline that Jani sent). So there's no rush in reviewing the API right now, as we've given us time to change it for 5.7. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
