On Fri, Sep 18, 2015 at 10:39 AM, Knoll Lars <lars.kn...@theqtcompany.com> wrote: > On 18/09/15 09:59, "Albert Astals Cid" <albert.ast...@canonical.com> wrote: > >>On Fri, Sep 18, 2015 at 9:36 AM, Knoll Lars <lars.kn...@theqtcompany.com> >>wrote: >>> New properties: >>> >>> QQuickFramebufferObject::mirrorVertically, looks ok >>> QQuickPaintedItem::textureSize, not ok. It’s not versioned. >>> >>> New methods: >>> >>> * QQuickTextureFactory *textureFactoryForImage(const QImage &image), >>>docs >>> not ok IMO. >> >>What's would you add to the docs? > > The docs say “Returns a QQuickTextureFactory holding given the image.”.
So should i move "the" in front of "given" ? > For me that’s a parse error ;-) > It also doesn’t describe when and how you’re supposed to use the method. QQuickImageResponse::textureFactory says you can use that function when you need it to do exacly what it says, get a QQuickTextureFactory holding a QImage. If you prefer i can also reference QQuickImageResponse::textureFactory from textureFactoryForImage but it can (and is) also used in other places (at least internally, not sure if from a Qt user point of view would make sense in any other place). Salut, Albert > > Cheers, > Lars > _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
