On Friday 04 December 2015 08:39:55 Olivier Goffart wrote: > > Note that for widgets, the order is not pure luck. The order of children > > of > > a QWidget implies the tabbing order. Therefore, it is usually > > well-defined. > > The tab order is set with QWidget::setTabOrder and does not depends on the > order of the children.
You're right. I seem to remember the order being important for tabbing, but I guess it's something from before Qt 4 then. Ok, that argument is gone. > > Right now, connectSlotsByName simply uses findChildren's order. If we > > decide to change the order in one but not the order, I'd like to hear a > > compelling reason why it's ok for them be different. [cut part about findChild, which is not relevant] > FindChildren does not document the order. > So the order is then unspecified. > > Changing the order of findChildren would make the function slower. > Changing the order in connectSlotsByName would only make that function > slightly slower. > > I do not have strog opinion if the two functions must follow the same order. For cleanliness purposes, I would prefer both functions get changed. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
