This looks good. Cheers, Lars
On 03/03/16 08:59, "Development on behalf of Koehne Kai" <[email protected] on behalf of [email protected]> wrote: >IMO > >https://codereview.qt-project.org/#/c/151180/1/qtserialbus.pro > >should fix it. Is there a bug report already that I can link to? > >Regards > >Kai > >> -----Original Message----- >> From: Development [mailto:development- >> [email protected]] On Behalf Of >> Thiago Macieira >> Sent: Thursday, March 03, 2016 8:54 AM >> To: [email protected] >> Subject: Re: [Development] Dropping qtserialbus from Qt 5.6 -- it doesn't >> compile in C++98 >> >> On quinta-feira, 3 de março de 2016 07:50:51 PST Knoll Lars wrote: >> > >It matters because it breaks the build. >> > > >> > >Please remove it from the build. It's ok for it to be present, but >> > >don't compile it. >> > >> > >> > Which build are you talking about? The split source packages shouldn't >> > have a problem with this. >> >> The convenience build for the "qt-everywhere" tarball. >> >> > For the unified source packages, we should probably simply skip the >> > module if the compiler is not c++11 compliant. >> >> Please see Stefan Walter's email. He got failures while using -std=c++0x, so >> this trick won't work. >> >> > But I see no reason to remove it >> > for compilers that can handle it. It's certainly not different from >> > other modules such as web engine that also have stricter requirements >> > on compilers or platforms than e.g. Qtbase. >> >> So long as they don't break the build. >> >> -- >> Thiago Macieira - thiago.macieira (AT) intel.com >> Software Architect - Intel Open Source Technology Center >> >> _______________________________________________ >> Development mailing list >> [email protected] >> http://lists.qt-project.org/mailman/listinfo/development >_______________________________________________ >Development mailing list >[email protected] >http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
