The problem seem purely license related (other failures currently not visible). I would argue that we should fix integrations errors due to such issues.
I would favor another option though. We should disable the license check for modules which are ignored by .gitmodules. -- Alex ________________________________________ From: Development <development-bounces+alexander.blasche=theqtcompany....@qt-project.org> on behalf of Robin Burchell <[email protected]> Sent: Tuesday, March 22, 2016 10:50 To: [email protected] Subject: Re: [Development] qtfeedback and qtdocgallery: status? On Tue, Mar 22, 2016, at 10:37 AM, Hausmann Simon wrote: > I'm not sure what you'd like me to answer at this point. I think that it > is possible to fix the > build of these modules, the CI system is in place for that. However it > requires a fair bit of > work (ask Robin about qtmessagingframework ;-). Assuming that the problems are *just* limited to license tests, and the tests in the package itself are in good shape, then it's probably not *too* hard. It'll still require playing a few rounds of CI ping-pong, and mass-staging changes (and headdesking when it fails again). I'll readily admit that it's an annoying process, but it was a manageable one. I'm not sure it's a productive use of time in the case of these "smaller"/pseudo-abandonware codebases, but it's certainly possible. For the practicalities of how to do it (Simon or someone, please correct me if I'm wrong here): * You'll want to edit sync.profile in the module and make sure they don't have "stale" dependencies (I see for instance that qtfeedback is pointing to refs/heads/stable, which is probably not a good idea at this point). I forget what the default is (no specific version listed) -- I believe it points to the origin branch (e.g. 5.6 branch of module -> 5.6 of dependency), or dev if there's not a direct match. * You can run the license test locally (from qtqa, see ./tests/prebuild/license/tst_licenses.pl) to check that it will be satisfied with a given module Robin _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
