Hi Steve,
Thanks for actually stepping up the plate to create a contribution!
It looks fine to me, but I cannot approve this myself.
https://codereview.qt-project.org/158402
André
Op 05/05/2016 om 19:34 schreef Steve Schilz:
Hi Andre,
Challenge Accepted!
I have looked at this before and found it a lot to get set up. I really need to
get over the hump so that I can do this.
If I understand correctly, docs are generated from comments in the source code…
I have JIRA and Gerrit accounts, and am familiar with downloading building Qt.
So my next steps are
* Accept the contribution agreement
* Clone Qt - Which branch? 5.8?
* prepare a patch altering the docs in the source code comments, submit to code
review…
**** QUESTION ***** Who do I put as reviewer for this change?
Steve Schilz
PASCO scientific - think science
On 5/4/16, 11:06 PM, "André Somers" <[email protected]> wrote:
I think it does make sense. How about a making a small contribution to
Qt to fix this?
André
Op 05/05/2016 om 01:25 schreef Steve Schilz:
Oops, I ment QTextDocument::setPageSize
(http://doc.qt.io/qt-5/qtextdocument.html#pageSize-prop)
Does that make more sense?
Steve Schilz
PASCO scientific - think science
On 5/4/16, 2:17 PM, "Giuseppe D'Angelo" <[email protected]> wrote:
Hi,
On Wed, May 4, 2016 at 10:09 PM, Steve Schilz <[email protected]> wrote:
The doc is confusing because it does not specify a unit for the input
parameter “pageSize"
The parameter is of type QPageSize, which has multiple setters and
constructors. Which one(s) is missing the unit specification?
Thanks,
--
Giuseppe D'Angelo
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development
