On 25/10/2016 09:22, Jedrzej Nowacki wrote:
I would like to also remind everyone, that intermodule API changes
need to be merged in two steps. For example if you plan to change a
method "void foo()" in qtbase to "void foo(const QString&)", that
would be the right order of execution: 1. Commit a change to qtbase
that _adds_ foo(const QString&) 2. Update all modules that use foo()
to use foo(const QString&) 3. Wait until Qt5(dev branch) submodule
update, that gathers changes from 1 and 2 4. Remove old foo() from
qtbase If you do not follow we would have to revert your changes.
What happened to pinned sync.profile %dependencies? That seems like a
much smoother workflow:
1. pin qtbase sha in dependent module
2. update qtbase, changing method in one go
3. update dependent module to use new api, along with an unpin qtbase sha
This doesn't split the logical change in qtbase into two just to keep
the world building.
tor arne
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development
