> On 19 Jun 2017, at 17:34, Thiago Macieira <thiago.macie...@intel.com> wrote:
> 
> On Monday, 19 June 2017 03:48:42 PDT Morten Sørvig wrote:
>> - Can we self-test the network interface and QSKIP if it’s not in working
>> order?
> 
> That's the test itself: it tries to send a packet back to itself and see if 
> it 
> arrives.

Yes, but the system under test is the Qt network stack, not the OS network 
stack.
So if the OS network stack is missing or not operable that’s a N/A result, not 
a fail.

Though as a practical matter having a test sometimes SKIPs based on external 
conditions
might be too unpredictable.

> 
>> - We can blacklist on CI only:
>> https://codereview.qt-project.org/#/c/197692/ (modifying that patch to
>> blacklist all Linux CI if needed.)
> 
> I don't believe in blacklisting if we can find and fix the root cause. That's 
> what I did for the "utun" interface on Darwin machines, when a blacklist was 
> proposed. But I haven't been able to figure that out for RHEL yet.

I agree that getting to the root cause is preferable. We can do both: blacklist
immediately to get integrations going again while investigating.

Morten
_______________________________________________
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to