On fredag 22. desember 2017 09.17.47 CET Tony Sarajärvi wrote: > Hi > > We ignore the results of PS1 scripts because A) We have bad scripts that try > to remove folders that don't exists anymore (should be cleaned) and B) as > your example said, if we enabled enforcing of them now, things would break > apart (fix needed as well 😝)
I would consider this a major bug. We never intended to ignore errors in the PS scripts and shouldn't. https://bugreports.qt.io/browse/QTQAINFRA-1178 considered this a P0 and should be re-opened if we have this happening again. Cheers, Frederik > -T > > -----Original Message----- > From: Development > [mailto:development-bounces+tony.sarajarvi=qt...@qt-project.org] On Behalf > Of Konstantin Tokarev Sent: torstai 21. joulukuuta 2017 20.37 > To: development@qt-project.org > Subject: [Development] Reporting errors for powershell scripts executed by > Coin > Hi all, > > AFAIU, some time ago Coin considered ps1 script to be failed its exit code > was non-null (e.g, Exit(1) certainly aborted further provisioning > process). > Now I see that Exit(1) is ignored (see [1]). What is the correct way now, > throw exception? > [1] > https://testresults.qt.io/coin/api/results/provisioning/qtci-windows-10-x86 > _64-10-f8e8db/provision_1513869138/log.txt.gz > Words "conan exited with code 1" are printed before script does Exit(1) > > > > -- > Regards, > Konstantin > _______________________________________________ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development > _______________________________________________ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development