I would be for that, considering there doesn't seem to have been a clear reason for making it public in either the commit message or docs.
From: Simon Hausmann Sent: Friday, 5 January 2018 3:11 PM To: Mitch Curtis <[email protected]>; [email protected] Subject: Re: QQmlAbstractUrlInterceptor Hi, I don't know either to be honest, this was a long time ago it seems. Perhaps we should consider marking the class \internal, as its "setter" on QQmlEngine is \internal, too. The feature that is public and document and that uses QQmlAbstractUrlInterceptor under the hood is QQmlFileSelector. Simon ________________________________ From: Development <[email protected]<mailto:[email protected]>> on behalf of Mitch Curtis <[email protected]<mailto:[email protected]>> Sent: Friday, January 5, 2018 3:06:58 PM To: [email protected]<mailto:[email protected]> Subject: [Development] QQmlAbstractUrlInterceptor While looking into https://bugreports.qt.io/browse/QTBUG-65444, I noticed that QQmlAbstractUrlInterceptor is a public class with documentation that doesn't really explain how to use it. See my comment here: https://bugreports.qt.io/browse/QTBUG-65444?focusedCommentId=385687&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-385687 Here's an old mailing list thread I found about it: http://lists.qt-project.org/pipermail/development/2013-July/011914.html Why was a public class added that can seemingly only be used with private API? Why did it have to be made public? And why doesn't the documentation actually explain how to use it? _______________________________________________ Development mailing list [email protected]<mailto:[email protected]> http://lists.qt-project.org/mailman/listinfo/development
_______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
