Hi Paul,
Am 27.04.2018 um 10:52 schrieb Paul Colby:
Hi,
I want submit a very small bug fix to the QtXmlPatterns module. I think
I have git and Gerrit all setup, but just wanted to confirm a two things.
The bug to be fixed has been present, untouched since at least Qt 4.6.
Looking at the QUIP5 guidelines, I'd say its classified as "Bugs: Other"
(ie, not a regression, or crash), which suggests the Gerrit ref should
be "Stable". So then, should I be doing:
git push gerrit HEAD:refs/for/5.10
That would be correct in principle, but 5.10 is already closed.
Please use 5.11. (Please note that we can move patches later easily
within Gerrit also).
Also, is it considered helpful / good practice to create a bugreport in
JIRA to associate with the push, or that considered unecessary noise?
If it's a small fix, then usually not. You can of course search if
someone else has reported it already and then integrate a
Task-number: QTBUG-12345
in your commit message, directly above the Change-Id line.
Thanks! :)
You're welcome :)
André
Paul.
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development
--
Dipl.-Ing. (FH) André Hartmann
Softwareentwicklung / Software Development
E-Mail: [email protected] | Tel: +49 351 26996-43 | Fax: +49 351
26996-21
iseg Spezialelektronik GmbH - HIGH VOLTAGE. EXACTLY.
iseg-hv.de | iseg-hv.com | download.iseg-hv.com
Bautzner Landstr. 23, 01454 Radeberg / Rossendorf, Germany
Geschäftsführer / Managing directors: Dr. Frank Gleisberg, Dr. Joachim
Pöthig
Amtsgericht / Lower district court: Dresden HRB 16250
Umsatzsteuer-Id: / VAT-ID: DE812508942
News / Information
https://iseg-hv.com/en/products/control#isegControl2 isegControl2 -
Unified Control Software
https://iseg-hv.com/en/products/detail/EHS EHS FLEX - Customize and keep
the price
https://iseg-hv.com/en/products/detail/EHS EHS STACK - Perfect for GEM
Detectors
https://iseg-hv.com/files/iseg-high-voltage-power-supplies.pdf NEW!
Product catalog 2017 / 2018 released
https://iseg-hv.com/en/products/detail/NHR NHR - NIM HV-Supply with
reversible polarity
Links
https://www.linkedin.com/company/12726924 iseg on LINKEDIN | Let's stay
connected!
https://www.youtube.com/channel/UC5AL-ZgOqSim_1gYNnndyzQ iseg on YOUTUBE
| Tutorials and more ...
https://www.twitter.com/iseg_hv iseg on TWITTER | please follow!
https://iseg-hv.com/files/iseg-high-voltage-power-supplies.pdf iseg
CATALOG | download product catalog as PDF
http://download.iseg-hv.com/ iseg DOWNLOADS | manuals, software,
firmware and more...
Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
Informationen. Wenn Sie nicht der richtige
Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren
Sie bitte sofort den Absender und
vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte
Weitergabe dieser Mail ist nicht
gestattet.
This e-mail may contain confidential and/or privileged information. If
you are not the intended recipient
(or have received this e-mail in error) please notify the sender
immediately and destroy this e-mail.
Any unauthorized copying, disclosure or distribution of the material in
this e-mail is strictly forbidden.
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development
