> As such, the repository should be readable by everyone, but write access
> should be limited to The Qt Company.
>
> I don’t understand how would that solve the issue. Wouldn’t this repo need
> to be cloned and then (somehow) merged with qtbase?
Yes, it would be a git submodule of qtbase.
> If public
> read/download access if not a concern, wouldn’t it make more sense to just
> add licheck and the licenses to qtbase repo?
That would indeed be the easiest. I proposed a separate submodule because
a) binary checkins will blow up repository content over time, which we should
avoid for central modules like qtbase.
b) people that want to just use the opensource version or a tech preview
version can just ignore the submodule.
Alternatively, the submodule can also be a qt5.git submodule, instead of a
qtbase one. The logic in qtbase could still locate a repository relative to
qtbase.
Kai
________________________________
From: Stottlemyer, Brett (B.S.) <bstot...@ford.com>
Sent: Friday, May 18, 2018 4:45:20 PM
To: Kai Koehne; development@qt-project.org
Subject: Re: [Development] Repository Request: qt/licensing
On 5/18/18, 10:36 AM, "Development on behalf of Kai Koehne"
<development-bounces+bstottle=ford....@qt-project.org on behalf of
kai.koe...@qt.io> wrote:
Hi,
I'd like to request the creation of a repository "qt/licensing" on
codereview.qt-project.org. This will become an optional git submodule of qtbase
(checkout: qtbase/licensing).
The repository will contain the Licenses and binary files (licheck*) that
are so far only in our commercial source packages. The goal is to allow proper
commercial builds from git, see also
https://bugreports.qt.io/browse/QTBUG-52222.
As such, the repository should be readable by everyone, but write access
should be limited to The Qt Company.
I don’t understand how would that solve the issue. Wouldn’t this repo need to
be cloned and then (somehow) merged with qtbase? If public read/download
access if not a concern, wouldn’t it make more sense to just add licheck and
the licenses to qtbase repo?
Brett
_______________________________________________
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
