On Mon, Jan 28, 2019 at 12:54:58PM +0000, Volker Hilsheimer wrote: > > Wouldn't we expect those external patchers to submit changes to dev > > only? Then the module maintainer, or an LTS version maintainer (is > > there a maintainer for each LTS version?) would decide whether the > > change should be cherrypicked into an LTS version. > > > > martin > > > Indeed; esp in the cases where a causal contribution comes in, and > where then the maintainers need to invest time to decide whether or > not this is material for a stable branch, dev should be the first > branch. > > A change making it into dev where it can be noticed and scrutinized by > a bunch of people that didn’t participate in the merge request, where > it can pass additional build and configurations, and generally be > exposed to different cases that are not covered by CI - isn’t that > valuable?
I would think so. Also, in the not-so-uncommon case where there is no really obvious target branch (e.g. because reviewers disagree on whether it's LTS material), people who really want to have that change in another branch for which there was no consensus in the initial review are free to attempt porting the change to that branch, using mainly their own resources, which looks like a fair deal to me under these circumstances. Andre' _______________________________________________ Development mailing list [email protected] https://lists.qt-project.org/listinfo/development
