On fredag 15. februar 2019 12:21:43 CET Martin Koller wrote: > On Freitag, 15. Februar 2019 11:08:18 CET Andy Shaw wrote: > > Since it has the +2 you can click on the "Merge patch 2 to staging" now, > > is that button showing up for you? > ah, great. Was not aware that I needed to trigger that. > My fault. Was thinking the maintainer does that.
Thank you for contributing to Qt Martin! This goes of course for all contributors, it's greatly appreciated that you make Qt better! Sometimes Gerrit (especially the old version running on codereview.qt- project.org) is not the most obvious to use. For the people regularly using it, it tends to work nicely, but I can understand how it's just different enough from other Git workflows to be confusing. Cheers, Frederik > Thanks! > > > Andy > > > > -----Opprinnelig melding----- > > Fra: Development <[email protected]> på vegne av Martin > > Koller <[email protected]> Dato: fredag 15. februar 2019 11:04 > > Til: "[email protected]" <[email protected]> > > Emne: [Development] codereview, merge please > > > > Hi, > > > > I made a patch here > > https://codereview.qt-project.org/#/c/249171/ > > > > but it's still not merged. > > Did I forget something ? _______________________________________________ Development mailing list [email protected] https://lists.qt-project.org/listinfo/development
