I commented on one exact situation: if we rename QAbstractSocket::error(QAbstractSocket::SocketError) signal then we can easily grep sources for all Qt4-style connections to this particular signal (because it has a very special signature). There is a place for false-positives but I think it is acceptable.
On Fri, Feb 7, 2020 at 12:38 PM Mark De Wit <[email protected]> wrote: > > > Edward Welbourne > > > Alexander Akulich (6 February 2020 16:33) asked: > > > Are we going to provide some Qt5 → Qt6 migration tool? > > > > https://codereview.qt-project.org/c/qt/qtrepotools/+/289121 > > > > > It is trivial to grep the sources for > > > "SIGNAL(error(QAbstractSocket::SocketError))" and print a warning > > > about the dangerous Qt4-style connection. > > > > Check with Friedemann on the review, but I suspect he'd welcome a patch that > > adds that to the tool. > > I think clazy has a check for this already? > > https://github.com/KDE/clazy/blob/master/docs/checks/README-old-style-connect.md > > Mark _______________________________________________ Development mailing list [email protected] https://lists.qt-project.org/listinfo/development
