I second this, it looks like a useful addition. If it improves the contribution 
experience for a group of contributors, I'd say this is a no-brainer. Feel free 
to add me to the review(s), Cristian!

Kind regards,

Paul Wicking
Staff Software Engineer
Qt Group

On 12 Feb 2025, at 17:52, Marc Mutz via Development 
<development@qt-project.org> wrote:

On 12.02.25 11:43, Cristian Le via Development wrote:
I want to gather some feedback about adding a .gitreview file for all
repos. The file would look like

```
[gerrit]
host=codereview.qt-project.org<http://codereview.qt-project.org/>
project=qt/qtbase
defaultbranch=dev
```

I wouldn't mind, looks rather static, so maintenance should be minimal
(basically not forgetting to add it to new modules).

This would help with out-of-the-box support for some IDEs, e.g. on
Jetbrains ones it read this file to determine the default for where to
submit the gerrit reviews.

If you have git-review cli you also have more simple interface to submit
and fetch changes, e.g.
```
(Cherry-pick gerrit change)
$ git review -x <Change-ID>
(Submit a change)
$ git review -s 6.9
```

For new external contributors this also signals straight away that the
projects are managed by gerrit and where to submit the changes.

For more reference about the .gitreview check the upstream documentation
[1]. There is also a Jira bug I've opened about adding this file [2].

[1]:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.opendev.org%2Fopendev%2Fgit-review%2Flatest%2Finstallation.html%23gitreview-file-format&data=05%7C02%7Cpaul.wicking%40qt.io%7C76c3db92996f48897b4008dd4b862e1a%7C20d0b167794d448a9d01aaeccc1124ac%7C0%7C0%7C638749761847757895%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=nJ7IkCi%2FKhgD1dkfUyf8w%2FQZ48rTop7WZ4Hs6XnJfds%3D&reserved=0<https://docs.opendev.org/opendev/git-review/latest/installation.html#gitreview-file-format>
[2]: https://bugreports.qt.io/browse/QTBUG-132604


--
Marc Mutz <marc.m...@qt.io<mailto:marc.m...@qt.io>> (he/his)
Principal Software Engineer

The Qt Company
Erich-Thilo-Str. 10 12489
Berlin, Germany
www.qt.io<http://www.qt.io/>

Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni Lintunen
Sitz der Gesellschaft: Berlin,
Registergericht: Amtsgericht Charlottenburg,
HRB 144331 B

--
Development mailing list
Development@qt-project.org<mailto:Development@qt-project.org>
https://lists.qt-project.org/listinfo/development

-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Reply via email to