On Monday, 17 March 2025 01:11:59 Pacific Daylight Time Marc Mutz via Development wrote: > I don't know how this goes in other modules, but in qtbase, I have been > bitten so many times in the last weeks by missing cherry-picks that the > issue needs some discussion. I don't want to step on any particular > person's toe here, because the issue is systemic, so I wont, but I could > point out several issues in the last weeks where author + reviewer just > didn't work.
That's probably because you're doing the cherry-picking of changes that aren't yours, and thus don't remember the dependencies that would have applied the necessary changes because you hadn't made them in the first place. And because you're being stricter in which branches to pick to than most other contributors. In some cases, the dependencies that are missing were trivial changes that QUIP-16 says shouldn't be picked in the first place. They weren't dependencies of a larger changes when they were made; they were simple clean-ups at the time. The example that shows this is the TinyCBOR 0.6.1 change[1]. You said you spent 12 minutes trying to figure out why it was conflicting. It took me about 15 seconds because I knew that the change was a simple fix for a -Wundef warning[2], made two months before. Whether we can call this systemic or not, I don't know. I do appreciate a reminder of what we should be picking to, and in fact I agree on having guidelines, but as Volker says, the contributors in question make a decision. And as I said a few weeks ago, I've delegated the authority on what those targets should be for QtCore changes to you. All contributors to QtCore shall abide by your recommendations. [1] 7df128675a22391bc3ade2a45b558bc38eee1c67 [2] 34f60877bdb54786c62fd1bf5b44a81430aa411f -- Thiago Macieira - thiago.macieira (AT) intel.com Principal Engineer - Intel DCAI Platform & System Engineering
smime.p7s
Description: S/MIME cryptographic signature
-- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
