ok, one more fix, I just checked it in:
http://svn.apache.org/viewvc?view=revision&revision=1496530 So I basically made a new class for patterns: http://svn.apache.org/viewvc/incubator/devicemap/trunk/devicemapjava/src/main/java/org/apache/devicemap/client/data/Pattern.java?view=markup Before it was List<String>, now we have a list of lists: List<List<String>> and this is encapsulated in the new Pattern class. Basically, the outer list are OR patterns, only one in the set needs to match, and the inner list are AND patterns, all patterns in the inner set needs to match. Ex: [ [pattern1] , [pattern2 , pattern3] ] So this pattern has 2 sets, either one has to match (this is the outer OR list). The first set is a single pattern: pattern1. The 2nd set is pattern2 and pattern3 and both need to match since the inner sets are AND. And example of an inner AND set is the TwoStepBuilder. So this changed the classify method starting at line 91: http://svn.apache.org/viewvc/incubator/devicemap/trunk/devicemapjava/src/main/java/org/apache/devicemap/client/DeviceMapClient.java?view=markup That loop just validates that one complete set of patterns is a valid match. I think this may correct a good number of unknowns or mismatches. ________________________________ From: eberhard speer jr. <[email protected]> To: Apache Device Map DEV <[email protected]> Sent: Tuesday, June 25, 2013 12:38 PM Subject: Re: DeviceMapClient - results -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 hehe, fixed it... No regex huh ? Ha ! In java split() takes regex as parameter and that's what bit me (use Regex.Split() in .Net). Also the GoTo threw me off... Anyway, fixed it and updated the zip file (same location, same file etc) Now the match, after removing WHERE DMap = 'unknown', is 70% ! Nice ! esjr -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRyceiAAoJEOxywXcFLKYcHUQH/iIDx7951QzX7V62yA7CO9Yn vnBhjBUcS6H1qZg8nccNUOYoWtCgtQKSAToCPblfI3AZ++nBP69Lrph/XCWkpPss knmvrxY1sj2mg0gHxf4mGx8H7ESf08L7pxrAnygR5O2tghLxJucOIpLT8iwvx3w8 Ja6UycQuohX0CQkSfzuVgGVNFTqFFg/gR4bI7KJhZf8F5R2q2fZO1H5V7cFmJ8si 0DnsU6vF6ropTlTp5lH5LCbi/xbz/P04S53fmcz2XNsu5E/or3Tmi5u+6vZmt02Y qQCXbTWLMNmprG5nZKAmVgAs5vetq5ieCVm5ElWobGQAqrYJh851LivJNQKCClM= =Bh/P -----END PGP SIGNATURE-----
