First, apologies for the late vote. All looks good to me, with a few exceptions:
LICENSE/NOTICE files are not being included into META-INF/ directory of the devicemap-data-1.0.0.jar or devicemap-client-1.0.0.jar files. They're expected to be there. maven can be configured to do this automatically. This is minor, IMO. However, a review by incubator might require it... The copyright date in the NOTICE files is 2013. It should be 2014. This is minor. Here is my +1 with the above notes. --kevan On Wed, Jul 16, 2014 at 7:43 PM, Reza <[email protected]> wrote: > This is the official vote thread. > > The release is located here: > > http://devicemap-vm.apache.org/releases/1.0.0/ > > > README for the release with notes, links, and instructions: > > http://devicemap-vm.apache.org/releases/1.0.0/README.html > > Please vote to approve this release: > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > > Thanks! > > Reza >
