Hi Radu, +1
I have one minor comment. The NOTICE file includes the following text, which should be deleted: Apache DeviceMap includes subcomponents with separate copyright notices and license terms. Your use of these subcomponents is subject to the terms and conditions of those licenses. This does not need to block a release. However, should be fixed in trunk. On Fri, Jul 18, 2014 at 3:41 PM, Radu Cotescu <[email protected]> wrote: > Hi, > > I've staged yet another set of release artifacts after eliminating some > redundant development dependencies. I've also updated the README.md file to > remove some of the instructions advising on installing 'jscoverage' > globally. > > Due to the fact that I've used version 1.4.1-rc1 in package.json, the > previously staged artifacts were not compliant for a 1.4.1 release. I've > now updated package.json to indicate a 1.4.1 release, while the newly > staged artifacts are named like browsermap-1.4.1-rc2-incubating.tar.gz*. > > After the vote passes, renaming them to 1.4.1 won't change the checksums > and the package.json will indicate the correct version. > > A full diff between rc1:rc2 can be found at > https://gist.github.com/raducotescu/f876348e82183d412a3d > > > ##################################################################################### > > Staging URL: https://people.apache.org/~radu/browsermap/ > > The project's keys file is available at: > https://people.apache.org/keys/group/devicemap.asc > > In case you need to import the keys, after downloading the keys file, run > the following command: > gpg --import devicemap.asc > > You can use this UNIX script to download the release and verify the > signatures: > > http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh https://people.apache.org/~radu/browsermap/ > > An Apache Creadur Rat exclude file is provided at > > http://svn.apache.org/repos/asf/incubator/devicemap/trunk/browsermap/trunk/rat.exclude > . > > To check the licensing compliance you could run the following command after > expanding the browsermap-1.4.1-rc2-incubating.tar.gz archive: > java -jar apache-rat.jar -E browsermap-1.4.1-incubating/rat.exclude -d > browsermap-1.4.1-incubating > > The current artifacts correspond to tag > > http://svn.apache.org/viewvc/incubator/devicemap/trunk/browsermap/tags/browsermap-1.4.1-rc2/ > . > > Once the release is approved we have to: > 1. tag the release under > > https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/browsermap-1.4.1 > 2. upload the new artifacts to the dist location > > Please vote to approve this release: > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > Regards, > Radu > > > On Thu, Jul 17, 2014 at 7:20 PM, Radu Cotescu <[email protected]> wrote: > > > Hi Bertrand, > > > > I've successfully built BrowserMap on a fresh Linux box (when it comes to > > Node.js and npm) and had no problems. I've also checked my environment > and > > I cannot see anything special which has not been covered by the module's > > README file regarding development. > > > > Therefore I'm inclining to think that there might be something which > > hasn't been set up as expected on your box - most probably related to > node, > > rather than the BrowserMap module. > > > > Regards, > > Radu > > > > On Thu, Jul 17, 2014 at 6:34 PM, Bertrand Delacretaz < > > [email protected]> wrote: > > > >> "sudo grunt package" works, so I guess that's really a problem with my > >> grunt/node environment > >> > > > > > > >
