Ya, grouping patterns is ok. Just got to test and make sure that doesnt open up any regression bugs for detection.
is_crawler must have slipped in. Will remove on 1.0.2. ________________________________ From: eberhard speer jr. <[email protected]> To: "'[email protected]'" <[email protected]> Sent: Tuesday, September 9, 2014 11:54 AM Subject: Re: Data 1.0.1 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, 1.0.2, sure, no problem. I also have builder resources generated that way, meaning no duplicates and all patterns grouped per device per builder. I mean : <device id="ABC"> <value>1</value> <value>2</value> <value>3</value> </device> instead of <device id="ABC"> <value>1</value> <value>2</value> </device> ... <device id="ABC"> <value>1</value> <value>3</value> </device> For 1.0.2 if ok-ed... With regard to the 1.0.1 I also noticed -- apart from the many defaults -- the patch file [need to talk about those] contains a non-existing property : is_crawler. Apart from that I'd say : 1.0.1 is not perfect but it contains no breaking stuff [except maybe is_crawler], nothing 'outrageous', so, provided we are clear about a fair and open-minded approach to the Big One : 2.0, I say : onward. esjr -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQEcBAEBAgAGBQJUDyKpAAoJEOxywXcFLKYcMrsH/iT+TWjpmzLYOWeFtu+NELeG XxppH87oaPbKt8H3Nj8iX+MuVwa6wwrOX0DjGYuUe1sircwH4rC4ipEMzlRyVLA4 eB1d3NN39W4z9dBCOtMrdgBjlOsWi98aw+kiBrZV2Pttgh3cn+1dANCGxYRYuXok CrcjGnF6iWGZOt2LQxvFpMGmf9iJuoN6VwD+9XmqhY/xxRdjJdCcOBlkk5zo5gvB nRUcN+b556tV3k6qaX16qk9LD02oO4vA6MrSMIDsl/ahaX7mk/K7d+QKOvSJKKx/ rQtinZYBIpJv4yVvj1DZuYXprB6brytAl8VROcT3TqzcaW8cY2+xQ7jT9Vp4bmA= =EXlC -----END PGP SIGNATURE-----
