On Fri, Feb 03, 2017 at 12:39:07PM -0500, Barry Warsaw wrote: > Over in LP: #1661515, a bug describes an ubuntu-image parsing error in the > defaults section of a gadget.yaml:
> https://bugs.launchpad.net/ubuntu-image/+bug/1661515 > The spec does not define what is allowed in the defaults section: > https://github.com/snapcore/snapd/wiki/Gadget-snap#gadget.yaml > The current ubuntu-image code assumes defaults can contain only a-zA-Z0-9 > for the <snap id> and the same plus dashes for the <key>. There is no > restriction on the <value>. > The bug happens because the <key> has a dot in it. The fix is easy, but leads > to questions hopefully Gustavo or someone else can authoritatively answer. > What characters should be allowed for the <snap id>, <key>, and <value> > values of the `defaults:` section? AIUI ubuntu-image will never consume these fields anyway, they're only for snapd's use. Is it better to future-proof ubuntu-image by making it maximally permissive on these fields? snapd parses the gadget.yaml before it ever returns it to ubuntu-image, so it's not as if ubuntu-image being strict helps us fail early. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ [email protected] [email protected]
signature.asc
Description: PGP signature
-- Devices mailing list [email protected] Modify settings or unsubscribe at: https://lists.snapcraft.io/mailman/listinfo/devices
