Andres Salomon wrote:
-/* For updating the device tree at runtime */
-extern void of_attach_node(struct device_node *);
-extern void of_detach_node(struct device_node *);
-

Minor points, but I'd recommend moving the declarations at the same
time as the definitions.  That is, move the of_attach_node declaration
in patch1 and of_detach_node declaration in patch2.


No problem,  I'll update the patches to do this.
---

===================================================================
--- test-devicetree.orig/include/linux/of.h     2009-11-18
17:34:36.000000000 -0600 +++
test-devicetree/include/linux/of.h      2009-11-18
19:26:53.000000000 -0600 @@ -187,4 +187,10 @@ const char *list_name,
const char *cells_name, int index, struct device_node **out_node,
const void **out_args); +#ifdef CONFIG_OF_DYNAMIC
+/* For updating the device tree at runtime */
+extern void of_attach_node(struct device_node *);
+extern void of_detach_node(struct device_node *);
+#endif
+
 #endif /* _LINUX_OF_H */

The trend seems to be a different header file per config option.
"of_dynamic.h" would be the logic extension of that..


Works for me, updated patches coming soon.

-Nathan Fontenot
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss

Reply via email to